Reverting supporting-variants-and-pods-configs-simultaneously #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reated a bug which cause the UITests project to import an unneeded pod used by the app project, since the xcconfig is shared between the app and the tests projects
arthurpalves
approved these changes
Oct 26, 2023
Generated by 🚫 Danger Swift against ed43656 |
arthurpalves
deleted the
revert-supporting-variants-and-pods-configs-simultaneously
branch
arthurpalves
added a commit
that referenced
this pull request
Oct 26, 2023
* FIX: Reverting supporting-variants-and-pods-configs-simultaneously, that created a bug which cause the UITests project to import an unneeded pod used by the app project, since the xcconfig is shared between the app and the tests projects (#233) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Nour Sandid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverted changes to fix bug which caused the UITests project to import an unneeded pod used by the app project, since the xcconfig is shared between the app and the tests projects
What does this PR do
How can it be tested
Tell us how to test these changes
Task
resolves #X (where
#Xis the number of an issue)Checklist:
make validationlocally with success