Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-9: Make a simple search bar #3

Merged
merged 9 commits into from
Oct 11, 2023
Merged

BI-9: Make a simple search bar #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e58b6ec
search-bar feature added
meenalnimje Sep 27, 2023
7987311
suggested changes added
meenalnimje Sep 29, 2023
36cf4e0
2nd review
meenalnimje Oct 2, 2023
6aa2e65
changes after 2nd review
meenalnimje Oct 2, 2023
f118309
merge commit fix
meenalnimje Oct 3, 2023
6f391ae
prettier formate
meenalnimje Oct 3, 2023
7e366c8
changes in stories
meenalnimje Oct 3, 2023
58db507
export removed
meenalnimje Oct 3, 2023
dcb4c1c
suggested changes made
meenalnimje Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 79 additions & 64 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
"dependencies": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just leaving this comment over here, but it is unrelated to this code. There are some minor reasons due to which the build failed. We'll require a passing build to merge this code to the main branch.

"autoprefixer": "10.4.16",
"next": "13.5.2",
"path": "^0.12.7",
"postcss": "8.4.30",
"promises": "^0.2.5",
"react": "18.2.0",
"react-dom": "18.2.0",
"tailwindcss": "3.3.3"
Expand Down
1 change: 1 addition & 0 deletions script/web-scraping-script-main/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
node_modules/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it better over here. We don't need to keep the whole code of the repository. For now we only need the JSON file for the search bar, so let's limit only that file in this project.

To remove this folder, you'll need to untrack the whole folder. For that you'll need to run the command:

git rm -rf --cached web-scraping-script-main

The rm command will be used to remove files. Since it's a folder with a lot of files we'll need to run this operation recursively using the -r flag, the -f flag means forcefully, it's used here so that even if the files are modified, git won't be able to prevent the deletion. The --cached is used to untack the files. This will modify the .git folder such that it'll stop looking for changes in the provided file or directory.

2 changes: 2 additions & 0 deletions script/web-scraping-script-main/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
To Scrape University data just run command
-->> node uniDataScraper.js
Loading