-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BI-51: Migrating web-app-client to TypeScript #23
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 3
Lines ? 27
Branches ? 5
========================================
Hits ? 27
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
After the first commit of this PR, i.e. "Migrated to TS ", the code is passing all checks. However we need to make sure we accidently dont miss out on any config change which may bother us later on. So I'll try to research bit more on TS migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work 💯,some small changes are there plz fix it,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final review done, @bacpactech's review is left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @meenalnimje and @ayushtiwari110 for your team work.
No description provided.