Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-51: Migrating web-app-client to TypeScript #23

Merged
merged 18 commits into from
Feb 11, 2024
Merged

BI-51: Migrating web-app-client to TypeScript #23

merged 18 commits into from
Feb 11, 2024

Conversation

ayushtiwari110
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c3a1b83). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #23   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         3           
  Lines           ?        27           
  Branches        ?         5           
========================================
  Hits            ?        27           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ayushtiwari110
Copy link
Contributor Author

After the first commit of this PR, i.e. "Migrated to TS ", the code is passing all checks. However we need to make sure we accidently dont miss out on any config change which may bother us later on. So I'll try to research bit more on TS migration.

src/app/page.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@meenalnimje meenalnimje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 💯,some small changes are there plz fix it,

Copy link
Contributor

@meenalnimje meenalnimje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final review done, @bacpactech's review is left

@bacpactech bacpactech changed the title Bi 51: Migrating web-app-client to TypeScript BI-51: Migrating web-app-client to TypeScript Feb 11, 2024
Copy link
Collaborator

@bacpactech bacpactech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @meenalnimje and @ayushtiwari110 for your team work.

@bacpactech bacpactech merged commit 66a841a into main Feb 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants