Bi 27: Review 1 #17
Closed
Bi 27: Review 1 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* search-bar feature added * suggested changes added * 2nd review * merge commit fix * prettier formate * changes in stories * export removed * suggested changes made * storybook for navbar and footer is added * footer position changed from sticky to relative * css changes in footer * change in css of footer * change-1:-spacing,footer title resolved and font style corrected * design changed in navbar acc. to design team * navbarlinks colour changed to black * error resolved * homepage storybook added * changes based on chromatic comments * size of navbar and footer decresed * alignment correction * another text alignment correction * navbar alignment changes * navbar logo size fixed * searchbar element visibility corrected && other elemnts of searchpage added * design and responsiveness added * color added in specific texts * after review suggested changes made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.