Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy code #168

Merged
merged 4 commits into from
Nov 22, 2024
Merged

remove legacy code #168

merged 4 commits into from
Nov 22, 2024

Conversation

LuiggiTenorioK
Copy link
Member

Related issue: #157

@LuiggiTenorioK LuiggiTenorioK self-assigned this Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.74%. Comparing base (e8a1a64) to head (d0a45eb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   65.33%   70.74%   +5.41%     
==========================================
  Files          52       52              
  Lines        1696     1528     -168     
  Branches      229      192      -37     
==========================================
- Hits         1108     1081      -27     
+ Misses        441      337     -104     
+ Partials      147      110      -37     
Flag Coverage Δ
fast-tests 70.74% <100.00%> (+5.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@LuiggiTenorioK LuiggiTenorioK marked this pull request as ready for review November 21, 2024 15:04
@LuiggiTenorioK LuiggiTenorioK linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

133 files changed 😆 CI is passing, so I guess +1?

@LuiggiTenorioK
Copy link
Member Author

133 files changed 😆 CI is passing, so I guess +1?

Code instrumentation helped to know which code is never imported/used ✨

@LuiggiTenorioK LuiggiTenorioK merged commit 787b0f2 into master Nov 22, 2024
3 checks passed
@kinow kinow deleted the rm-v3-legacy branch November 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy code from GUI v3
3 participants