Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff linter #45

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Add Ruff linter #45

merged 2 commits into from
Oct 22, 2024

Conversation

LuiggiTenorioK
Copy link
Member

I'm adding the Ruff linter to the GitHub action and fixing the current issues inside the project

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 44.01%. Comparing base (61a1e4e) to head (e3c65f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
autosubmitconfigparser/config/configcommon.py 0.00% 17 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   43.94%   44.01%   +0.06%     
==========================================
  Files           3        3              
  Lines        1570     1563       -7     
  Branches      403      402       -1     
==========================================
- Hits          690      688       -2     
+ Misses        807      802       -5     
  Partials       73       73              
Flag Coverage Δ
fast-tests 44.01% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1! Linked an issue for changed, and the coverage errors are because Luiggi changed files (cosmetic changes) and Codecov is asking "where are the tests" 😆 No tests needed for these linter changes IMHO.

:rtype: str
"""
return self.get_section([section, 'EXPORT'], "")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated!! ☝️ thanks!

@@ -1686,7 +1675,7 @@ def save(self):
Saves the experiment data into the experiment_folder/conf/metadata folder as a yaml file
:return: True if the data has changed, False otherwise
"""
changed = False
# changed = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked in #46

@LuiggiTenorioK LuiggiTenorioK merged commit 1782a55 into main Oct 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants