-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruff linter #45
Add Ruff linter #45
Conversation
30f8482
to
e3c65f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 43.94% 44.01% +0.06%
==========================================
Files 3 3
Lines 1570 1563 -7
Branches 403 402 -1
==========================================
- Hits 690 688 -2
+ Misses 807 802 -5
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1! Linked an issue for changed
, and the coverage errors are because Luiggi changed files (cosmetic changes) and Codecov is asking "where are the tests" 😆 No tests needed for these linter changes IMHO.
:rtype: str | ||
""" | ||
return self.get_section([section, 'EXPORT'], "") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated!! ☝️ thanks!
@@ -1686,7 +1675,7 @@ def save(self): | |||
Saves the experiment data into the experiment_folder/conf/metadata folder as a yaml file | |||
:return: True if the data has changed, False otherwise | |||
""" | |||
changed = False | |||
# changed = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked in #46
I'm adding the Ruff linter to the GitHub action and fixing the current issues inside the project