imaging update: overlay_images #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please note github does not show that we removed |
bgruening
reviewed
Nov 8, 2023
| </data> | ||
| <data format="png" name="out" from_work_dir="output.png"> | ||
| <filter>method_option['method'] == 'seg_contour'</filter> | ||
| </data> | ||
| </outputs> | ||
| <tests> | ||
| <test> |
There was a problem hiding this comment.
It would be nice if you could add expect_num_outputs https://docs.galaxyproject.org/en/latest/dev/schema.html#id94 to the tests. This is mainly to check that the filters are working on the outputs.
|
Thanks @thawn
The remove is shown as a renaming here. |
also fixed lint errors for the output name and label
somehow, the github CI produces a smaller png file. opened the PNG in GIMP and saved it with compression 9 and without exif data.
bgruening
approved these changes
Nov 8, 2023
|
Thanks @thawn! |
|
@bgruening you are welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed default output for the method option "Segmentation mask over image" to png so that it can be directly viewed in the browser.
closes issue #75
FOR CONTRIBUTOR: