Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bioformats2raw #72

Merged
merged 12 commits into from
Nov 15, 2023
Merged

Conversation

bugraoezdemir
Copy link
Contributor

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

tools/bioformats2raw/bf2raw.xml Outdated Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Outdated Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Outdated Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Outdated Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Outdated Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Show resolved Hide resolved
@bugraoezdemir bugraoezdemir marked this pull request as ready for review November 3, 2023 15:56
Copy link
Member

@kostrykin kostrykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bugraoezdemir

The linter fails due to an issue with the owner field in the .shed.yml, see my comments for that.

Also, the first test fails when I run planemo test --docker . locally:

bf2raw (Test #1): failed
bf2raw (Test #2): passed
bf2raw (Test #3): passed

The reported problem is:

Expecting value: line 1 column 1 (char 0)

tools/bioformats2raw/.shed.yml Outdated Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Outdated Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Outdated Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Outdated Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Show resolved Hide resolved
tools/bioformats2raw/bf2raw.xml Show resolved Hide resolved
kostrykin
kostrykin previously approved these changes Nov 15, 2023
@kostrykin kostrykin dismissed their stale review November 15, 2023 10:53

Sorry for the confusion, I didn't want to approve the PR yet, only the changes made recently… misleading UI

@kostrykin
Copy link
Member

https://github.com/BMCV/galaxy-image-analysis/actions/runs/6876332188/job/18701807360?pr=72#step:3:22

Files larger than 1M found
tools/bioformats2raw/test-data/filament.tif
tools/bioformats2raw/test-data/xy_12bit__plant.oir
Error: Process completed with exit code 1.

@bugraoezdemir
Copy link
Contributor Author

https://github.com/BMCV/galaxy-image-analysis/actions/runs/6876332188/job/18701807360?pr=72#step:3:22

Files larger than 1M found
tools/bioformats2raw/test-data/filament.tif
tools/bioformats2raw/test-data/xy_12bit__plant.oir
Error: Process completed with exit code 1.

OK, I will replace them with smaller files.

@bugraoezdemir
Copy link
Contributor Author

https://github.com/BMCV/galaxy-image-analysis/actions/runs/6876332188/job/18701807360?pr=72#step:3:22

Files larger than 1M found
tools/bioformats2raw/test-data/filament.tif
tools/bioformats2raw/test-data/xy_12bit__plant.oir
Error: Process completed with exit code 1.

OK, I will replace them with smaller files.

@kostrykin I have changed the test data.

@kostrykin
Copy link
Member

Thanks, @bugraoezdemir!

Regarding this, I tried changing the output format to ome.zarr, which works (the tests pass), but there is a warning:

WARNING:galaxy.model:Datatype class not found for extension 'ome.zarr'

I'm not sure what the state of this is in Galaxy. Shall we keep it on html or change to ome.zarr?

@bugraoezdemir
Copy link
Contributor Author

Thanks, @bugraoezdemir!

Regarding this, I tried changing the output format to ome.zarr, which works (the tests pass), but there is a warning:

WARNING:galaxy.model:Datatype class not found for extension 'ome.zarr'

I'm not sure what the state of this is in Galaxy. Shall we keep it on html or change to ome.zarr?

@kostrykin The fact that it passes the tests is a bit deceptive. I have locally tested it with planemo serve and the output was an empty file. So I would suggest that we keep this version with html and when ome.zarr is fully established as a Galaxy data type, we can update the tool accordingly.

@bgruening
Copy link
Collaborator

ome.zarr is unfortunately not ready yet as a datatype :(

@kostrykin
Copy link
Member

Alright, thank you all!

@kostrykin kostrykin merged commit f7ffeaf into BMCV:master Nov 15, 2023
10 checks passed
@kostrykin
Copy link
Member

kostrykin commented Nov 15, 2023

Deployment to toolshed failed due to the following error:

Could not update bioformats2raw
Failed to find repository for owner/name euro-bioimaging/bioformats2raw
Repository bioformats2raw updated successfully.
Could not update bioformats2raw
Failed to find repository for owner/name euro-bioimaging/bioformats2raw
Unexpected HTTP status code: 400: {"err_msg": "You already own a repository named bioformats2raw, please choose a different name.", "err_code": 400008}
Repository [bioformats2raw] does not exist in the targeted Tool Shed.
Failed to update metadata for repository 'bioformats2raw' on the main Tool Shed.
Repository contents updated but failed to update metadata for repository 'bioformats2raw' on the main Tool Shed.

https://github.com/BMCV/galaxy-image-analysis/actions/runs/6879105347/job/18710524827#step:6:224

I find the error message somewhat confusing. @bgruening You maybe know what this means?

My interpretation is that "Failed to find repository for owner/name euro-bioimaging/bioformats2raw" is the root cause? Does such a repository exist in the ToolShed?

kostrykin added a commit to kostrykin/usegalaxy-eu-tools that referenced this pull request Nov 16, 2023
bgruening pushed a commit to usegalaxy-eu/usegalaxy-eu-tools that referenced this pull request Nov 16, 2023
* adds latest revision of segmetrics

xref BMCV/galaxy-image-analysis#88

* adds latest revisions of segmetrics and superdsm

Adds latest updates from BMCV/galaxy-image-analysis#94

* adds bioformats2raw tool

xref BMCV/galaxy-image-analysis#72
@kostrykin kostrykin mentioned this pull request Feb 28, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants