-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bioformats2raw #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bugraoezdemir
The linter fails due to an issue with the owner
field in the .shed.yml
, see my comments for that.
Also, the first test fails when I run planemo test --docker .
locally:
bf2raw (Test #1): failed
bf2raw (Test #2): passed
bf2raw (Test #3): passed
The reported problem is:
Expecting value: line 1 column 1 (char 0)
lowercase owner field Co-authored-by: Leonid Kostrykin <[email protected]>
Co-authored-by: Leonid Kostrykin <[email protected]>
Co-authored-by: Leonid Kostrykin <[email protected]>
Sorry for the confusion, I didn't want to approve the PR yet, only the changes made recently… misleading UI
|
OK, I will replace them with smaller files. |
@kostrykin I have changed the test data. |
Thanks, @bugraoezdemir! Regarding this, I tried changing the output format to
I'm not sure what the state of this is in Galaxy. Shall we keep it on |
@kostrykin The fact that it passes the tests is a bit deceptive. I have locally tested it with |
ome.zarr is unfortunately not ready yet as a datatype :( |
Alright, thank you all! |
Deployment to toolshed failed due to the following error:
https://github.com/BMCV/galaxy-image-analysis/actions/runs/6879105347/job/18710524827#step:6:224 I find the error message somewhat confusing. @bgruening You maybe know what this means? My interpretation is that "Failed to find repository for owner/name euro-bioimaging/bioformats2raw" is the root cause? Does such a repository exist in the ToolShed? |
* adds latest revision of segmetrics xref BMCV/galaxy-image-analysis#88 * adds latest revisions of segmetrics and superdsm Adds latest updates from BMCV/galaxy-image-analysis#94 * adds bioformats2raw tool xref BMCV/galaxy-image-analysis#72
FOR CONTRIBUTOR: