Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve efficiency of colorize_labels tool wrapper + bugfix #131

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Improve efficiency of colorize_labels tool wrapper + bugfix #131

merged 3 commits into from
Sep 24, 2024

Conversation

kostrykin
Copy link
Member

@kostrykin kostrykin commented Sep 24, 2024 •
edited
Loading

  • Improve efficiency of colorize_labels tool wrapper (migrate from ndi.binary_dilation to ndi.distance_transform_edt)
  • Add failing test case to reproduce bug
  • Fix the bug. The bug occurred when nx.greedy_color produced more color labels than there were colors defined in matplotlib.colors.TABLEAU_COLORS. The fix is to use a colormap of variable length.

FOR THE CONTRIBUTOR — Please fill out if applicable

Please make sure you have read the CONTRIBUTING.md document (last updated: 2024/04/23).

  • License permits unrestricted use (educational + commercial).

If this PR adds or updates a tool or tool collection:

@kostrykin kostrykin marked this pull request as ready for review September 24, 2024 12:06
@kostrykin kostrykin merged commit 4344f54 into BMCV:master Sep 24, 2024
10 checks passed
@kostrykin kostrykin deleted the colorize-labels/dev branch September 24, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostrykin @bgruening