Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies of overlay_images tool #130

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

kostrykin
Copy link
Member

@kostrykin kostrykin commented Sep 23, 2024

Previous versions of the tool required numpy 1.20, that does not offer the numpy.typing package.

One of the other dependencies of the tool is scikit-image, which in turn requires pillow. When testing without containerization (i.e. without the --biocontainers switch), the tests failed, because seemingly a newer version of pillow was installed (10.4.0, compared to testing with containerization). However, pillow 10.4.0 requires the numpy.typing package, that isn't there with numpy 1.20:

AttributeError: module 'numpy.typing' has no attribute 'NDArray'

The same issue could be reproduced by running a local Galaxy instance without containerization (which is very much the procedure suggested in https://galaxyproject.org/admin/get-galaxy).

To fix these issues, this PR bumps numpy to 1.21 (which includes the numpy.typing package) and pins pillow to 10.4.0 (to prevent similar issues in the future).

Could be related to #121.


FOR THE CONTRIBUTOR — Please fill out if applicable

Please make sure you have read the CONTRIBUTING.md document (last updated: 2024/04/23).

  • License permits unrestricted use (educational + commercial).

If this PR adds or updates a tool or tool collection:

@kostrykin kostrykin merged commit 574caf0 into BMCV:master Sep 23, 2024
10 checks passed
@kostrykin kostrykin deleted the overlay_images/dev branch September 24, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant