Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix points2binaryimage tool #116

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Conversation

kostrykin
Copy link
Member

For the contributor:

Copy link
Collaborator

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to add creators

Squashed commit of the following:

commit 4e2755b
Author: Leonid Kostrykin <[email protected]>
Date:   Thu Mar 14 10:21:48 2024 +0000

    Add creators
@kostrykin
Copy link
Member Author

Nice to finally have the ability to specify creators in tool wrappers!
No idea how long this have been around, but I missed it until now :)

To reduce boilerplate, I think it would be nice to have reusable creators. I tried to achieve this with macros in 8453a6f.

@@ -0,0 +1,5 @@
<macros>
<xml name="creator">
<organization name="Biomedical Computer Vision Group" alternateName="BMCV" url="http://www.bioquant.uni-heidelberg.de/research/groups/biomedical_computer_vision.html" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably good to have a yield here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I have looked into yield but I do no see in what way you mean to use it here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yield will just allow us to add more organisations, creators on the per tool bases still inheriting this one. Think about it a substantial contribution from someone else that wants to be listed next to you.
A yield also does not hurt if you don't use it.

@bgruening bgruening merged commit 7830f8c into BMCV:master Mar 14, 2024
10 checks passed
@kostrykin kostrykin deleted the points2binaryimage/fix branch September 24, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants