Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile payments (CashMa, Africell, QMoney) #1

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

toch
Copy link

@toch toch commented Oct 12, 2023

Jira Ticket

Part of the mobile payments implementation done by 2M Corp

@toch
Copy link
Author

toch commented Oct 12, 2023

@Muskehline I work for Bluesquare. In order to support the discussion over the code, I've created this PR.

As you have reverted the commit, I don't know what can it be reviewed or not, and what comments I have on the previous version are still relevant to share. Could you please share and push the changes to review?

Also, it would help me to know what's the purpose of the change. For instance, what use cases they address and implement, or any assumptions considered.

Thanks in advance.

@toch
Copy link
Author

toch commented Oct 12, 2023

Could you do the same please for BLSQ/openimis-be-contribution_py on the branch feature/gambia-mobile-payments.

for BLSQ/openimis-be-mobile_payments_py could you put the code on a branch, that would ease the review and followup. Thanks in advance.

@aikumapayi
Copy link
Collaborator

Hi @toch i have read your email so we have a branch called feature/gambia that's where our code is been pushed to for both openimis_core and openimis_contribution, the mobile_payment is our own code so it pushed on the main.

You also mentioned about bugs on core and api_fhir that we should merge with the hotfix branch could provide specifications on that pls

@toch
Copy link
Author

toch commented Oct 13, 2023

@Muskehline

Hi @toch i have read your email so we have a branch called feature/gambia that's where our code is been pushed to for both openimis_core and openimis_contribution, the mobile_payment is our own code so it pushed on the main.

Please push that on a dedicated branch or we won't easily track the changes linked to that project. We are using the present repository for other changes too. Also if you push directly on the main branch, we won't be able to use Pull Request as the target is the main branch.

You also mentioned about bugs on core and api_fhir that we should merge with the hotfix branch could provide specifications on that pls

For api_fhir_r4, you need to work with the commit openimis/openimis-be-api_fhir_r4_py@e6c5076

For core, either you rebase your code on openimis/openimis-be-core_py@hotfix/cannot_pickle_celery as it's not yet merged, or you cherry pick the commit openimis/openimis-be-core_py@fb85fb7

@toch toch changed the title Core Update Mobile payments (CashMa, Africell, QMoney) Oct 13, 2023
@toch toch marked this pull request as draft October 13, 2023 12:11
@aikumapayi
Copy link
Collaborator

@Muskehline

Hi @toch i have read your email so we have a branch called feature/gambia that's where our code is been pushed to for both openimis_core and openimis_contribution, the mobile_payment is our own code so it pushed on the main.

Please push that on a dedicated branch or we won't easily track the changes linked to that project. We are using the present repository for other changes too. Also if you push directly on the main branch, we won't be able to use Pull Request as the target is the main branch.

You also mentioned about bugs on core and api_fhir that we should merge with the hotfix branch could provide specifications on that pls

For api_fhir_r4, you need to work with the commit openimis/openimis-be-api_fhir_r4_py@e6c5076

For core, either you rebase your code on openimis/openimis-be-core_py@hotfix/cannot_pickle_celery as it's not yet merged, or you cherry pick the commit openimis/openimis-be-core_py@fb85fb7

Hey @toch i want to know what core branch should i use to merge with the hotfix/cannot_pickle_celery. because when i took a look at the branch i saw that some migrations files were missing . i am using the core develop branch for all my changes

@toch
Copy link
Author

toch commented Oct 17, 2023

Hey @toch i want to know what core branch should i use to merge with the hotfix/cannot_pickle_celery. because when i took a look at the branch i saw that some migrations files were missing . i am using the core develop branch for all my changes

As the commit is very light you can merge the branch into yours, yours starting from the main one. Another option is to cherry-pick but you'll lose the ref to the original commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants