Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3731 Filter change requests by data_source_synchronization #1905

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

kemar
Copy link
Member

@kemar kemar commented Jan 8, 2025

Filter change requests by data_source_synchronization.

Related JIRA tickets : IA-3731

Doc

See the design specification linked in the aforementioned JIRA ticket.

Changes

  • backend:
    • allow to filter change requests by data_source_synchronization
    • allow to call the data_source_synchronization API and request only specific fields
  • frontend:
    • fix AsyncSelect to work with single choices as well as multi choices
    • add the freeSolo option
    • implement an autocomplete search input to filter change requests by data_source_synchronization names

Notes

  • some TypeScript types are unused now but will be useful in the future
  • the autocomplete mechanism seems to trigger a lot of HTTP queries, especially when the state changes
    • I'd like a specialist's opinion

How to test

  1. in the admin, create a "Data source versions synchronization":

  2. ensure your user has the following permissions:

    • SOURCE_WRITE
    • ORG_UNITS_CHANGE_REQUESTS_CONFIGURATION
    • ORG_UNITS
  3. in the UI, go to Validation > Review change proposals

    • you should be able to filter by "Data source versions synchronization"
    • filter

@kemar kemar self-assigned this Jan 8, 2025
@kemar kemar marked this pull request as ready for review January 8, 2025 16:31
@kemar kemar force-pushed the IA-3730-exclude-sync-change-requests-from-mobile branch from 88079e7 to 8aaf38c Compare January 9, 2025 16:32
@kemar kemar force-pushed the IA-3731-filter-change-requests-by-sync branch from 2862751 to 7a64fa1 Compare January 9, 2025 16:38
@kemar kemar force-pushed the IA-3730-exclude-sync-change-requests-from-mobile branch from 8aaf38c to 5d7a5c1 Compare January 13, 2025 10:59
@kemar kemar force-pushed the IA-3731-filter-change-requests-by-sync branch from a82151f to b491410 Compare January 13, 2025 11:00
@kemar kemar marked this pull request as draft January 15, 2025 08:47
@kemar kemar force-pushed the IA-3730-exclude-sync-change-requests-from-mobile branch from 5d7a5c1 to f9200aa Compare January 15, 2025 11:01
@kemar kemar force-pushed the IA-3731-filter-change-requests-by-sync branch from 2fe1841 to d9d33cd Compare January 15, 2025 11:01
@kemar kemar force-pushed the IA-3730-exclude-sync-change-requests-from-mobile branch from f9200aa to e6eb377 Compare January 15, 2025 11:31
@kemar kemar force-pushed the IA-3731-filter-change-requests-by-sync branch from d9d33cd to 3682606 Compare January 15, 2025 11:32
Base automatically changed from IA-3730-exclude-sync-change-requests-from-mobile to main January 15, 2025 11:37
@kemar kemar marked this pull request as ready for review January 21, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant