Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IA-3285] Fix FR typos #1901

Merged
merged 2 commits into from
Jan 6, 2025
Merged

[IA-3285] Fix FR typos #1901

merged 2 commits into from
Jan 6, 2025

Conversation

tdethier
Copy link
Member

@tdethier tdethier commented Jan 3, 2025

Fixing some typos in FR frontend

Related JIRA tickets : IA-3285

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

/

Changes

  • Updates to the fr.json file

How to test

/

Print screen / video

/

Notes

/

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@tdethier tdethier added the bug Something isn't working label Jan 3, 2025
@tdethier tdethier self-assigned this Jan 3, 2025
quang-le
quang-le requested changes Jan 6, 2025
View reviewed changes
hat/assets/js/apps/Iaso/domains/app/translations/fr.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, there's no space before punctuation signs like ?. and :

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In English yes, there is no space.
But in French, there should be a non-breaking space before :, ?, ! and other symbols like that.
(I tried to find the "official" rule in the Grevisse, but couldn't find an available version online, so Antidote sounded like the next best thing)

quang-le
quang-le requested changes Jan 6, 2025
View reviewed changes
hat/assets/js/apps/Iaso/domains/app/translations/fr.json
@@ -171,7 +171,7 @@
"iaso.devices.timeSynched": "Temps de synchronisation",
"iaso.devices.timeUpdated": "Dernière modification",
"iaso.duplicate.analysisBusy": "Analyse en cours",
"iaso.duplicate.latestAnalysis": "Dernière analyse terminée: {finishedAt}",
"iaso.duplicate.latestAnalysis": "Dernière analyse terminée : {finishedAt}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"iaso.duplicate.latestAnalysis": "Dernière analyse terminée : {finishedAt}",
"iaso.duplicate.latestAnalysis": "Dernière analyse terminée: {finishedAt}",

hat/assets/js/apps/Iaso/domains/app/translations/fr.json
@@ -219,7 +219,7 @@
"iaso.error.label.planningAndTeams": "Planning et équipes doivent faire partie du même projet",
"iaso.error.label.startDateAfterEndDate": "La date de début ne peut être après la date de fin",
"iaso.errors.label": "Une erreur est survenue.",
"iaso.errors.noPermissions": "Aucune permission n'est associée à cet utilisateur. Veuillez contacter un administrateur pour demander la(les) permission(s). Merci!",
"iaso.errors.noPermissions": "Aucune permission n'est associée à cet utilisateur. Veuillez contacter un administrateur pour demander la(les) permission(s). Merci !",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"iaso.errors.noPermissions": "Aucune permission n'est associée à cet utilisateur. Veuillez contacter un administrateur pour demander la(les) permission(s). Merci !",
"iaso.errors.noPermissions": "Aucune permission n'est associée à cet utilisateur. Veuillez contacter un administrateur pour demander la(les) permission(s). Merci!",

hat/assets/js/apps/Iaso/domains/app/translations/fr.json
@@ -320,11 +320,11 @@
"iaso.group.dialog.deleteText": "Cette opération ne peut-être annulée",
"iaso.groups.blockOfCountries": "Groupe de pays",
"iaso.groups.create": "Créer un groupe",
"iaso.groups.dialog.delete": "Etes-vous certain de vouloir effacer ce groupe?",
"iaso.groups.dialog.delete": "Etes-vous certain de vouloir effacer ce groupe ?",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"iaso.groups.dialog.delete": "Etes-vous certain de vouloir effacer ce groupe ?",
"iaso.groups.dialog.delete": "Etes-vous certain de vouloir effacer ce groupe?",

hat/assets/js/apps/Iaso/domains/app/translations/fr.json
"iaso.groups.dialog.deleteText": "Cette opération est définitive.",
"iaso.groups.sourceVersion": "Version de la source",
"iaso.groups.update": "Mettre le groupe à jour",
"iaso.groupsets.dialog.delete": "Etes-vous certain de vouloir effacer cet ensemble de groupe?",
"iaso.groupsets.dialog.delete": "Etes-vous certain de vouloir effacer cet ensemble de groupe ?",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"iaso.groupsets.dialog.delete": "Etes-vous certain de vouloir effacer cet ensemble de groupe ?",
"iaso.groupsets.dialog.delete": "Etes-vous certain de vouloir effacer cet ensemble de groupe?",

hat/assets/js/apps/Iaso/domains/app/translations/fr.json
"iaso.instance.details": "Voir les détails de la soumission",
"iaso.instance.device": "IMEI appareil",
"iaso.instance.dialog.editGpsFromInstanceTitle": "Voulez-vous vraiment pousser les GPS de la soumission à l'unité organisation ?",
"iaso.instance.dialog.editGpsFromInstanceTitle": "Voulez-vous vraiment appliquer les coordonnées GPS de la soumission à l'unité organisation ?",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"iaso.instance.dialog.editGpsFromInstanceTitle": "Voulez-vous vraiment appliquer les coordonnées GPS de la soumission à l'unité organisation ?",
"iaso.instance.dialog.editGpsFromInstanceTitle": "Voulez-vous vraiment appliquer les coordonnées GPS de la soumission à l'unité organisation?",

hat/assets/js/apps/Iaso/domains/app/translations/fr.json
@@ -359,7 +359,7 @@
"iaso.instance.formShort": "Formulaire",
"iaso.instance.formSubmissions": "Soumissions pour le formulaire",
"iaso.instance.infos": "Informations",
"iaso.instance.initialPeriodError": "La période actuelle sur la soumission est invalide: {period}",
"iaso.instance.initialPeriodError": "La période actuelle sur la soumission est invalide : {period}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"iaso.instance.initialPeriodError": "La période actuelle sur la soumission est invalide : {period}",
"iaso.instance.initialPeriodError": "La période actuelle sur la soumission est invalide: {period}",

hat/assets/js/apps/Iaso/domains/app/translations/fr.json
@@ -371,16 +371,16 @@
"iaso.instance.last_modified_by": "Modifié par",
"iaso.instance.last_sync_at": "Dernière synchro",
"iaso.instance.linkOrgUnitToInstanceReferenceWarning": "Cette opération peut toujours être annulée.",
"iaso.instance.lockAction": "Verrouiller la soumission?",
"iaso.instance.lockAction": "Verrouiller la soumission ?",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"iaso.instance.lockAction": "Verrouiller la soumission ?",
"iaso.instance.lockAction": "Verrouiller la soumission?",

hat/assets/js/apps/Iaso/domains/app/translations/fr.json
@@ -478,9 +478,9 @@
"iaso.label.dateTo": "Date de fin",
"iaso.label.day": "Jour",
"iaso.label.delete": "Effacer",
"iaso.label.deleteAttachment": "Effacer la pièce jointe: : {attachmentName}",
"iaso.label.deleteAttachment": "Effacer la pièce jointe : {attachmentName}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"iaso.label.deleteAttachment": "Effacer la pièce jointe : {attachmentName}",
"iaso.label.deleteAttachment": "Effacer la pièce jointe: {attachmentName}",

hat/assets/js/apps/Iaso/domains/app/translations/fr.json
"iaso.label.deleted": "Suppression",
"iaso.label.deletePlanning": "Effacer le planning: {planningName}",
"iaso.label.deletePlanning": "Effacer le planning : {planningName}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"iaso.label.deletePlanning": "Effacer le planning : {planningName}",
"iaso.label.deletePlanning": "Effacer le planning: {planningName}",

@tdethier tdethier merged commit b5eff4b into main Jan 6, 2025
3 checks passed
@tdethier tdethier deleted the IA-3285_fix-french-typos branch January 6, 2025 10:10
@kemar kemar added user tested Has already been tested on staging ok for release Released and removed ok for release labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quang-le quang-le quang-le approved these changes

Assignees

@tdethier tdethier

Labels
bug Something isn't working Released user tested Has already been tested on staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdethier @quang-le @kemar