Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLIO-1810: make check on grouped campaigns null safe #1900

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

quang-le
Copy link
Member

@quang-le quang-le commented Jan 3, 2025

What problem is this PR solving? Explain here in one sentence.

Related JIRA tickets : POLIO-1810

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

make check on grouped campaigns null safe in Dashboard.tsx

How to test

This is an edge case that I couldn't reproduce "naturally" so:

  • mock an API response from the campaigns API where a campaign doesn't have the grouped_campaigns key value

Print screen / video

NA

See Jira ticket for mink to initial sentry error

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@quang-le quang-le merged commit 0fe3651 into main Jan 6, 2025
3 checks passed
@quang-le quang-le deleted the POLIO-1810_null_error_polio_dashboard branch January 6, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants