Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLIO-1803: adapt supplychain to bopv/nopv new vaccine #1886

Conversation

quang-le
Copy link
Member

What problem is this PR solving? Explain here in one sentence.

Related JIRA tickets : POLIO-1803

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

  • Add model methods to return single vaccines on Round and Campaign:
    • Includes sub-activities scopes
  • Show individual vaccines for bOPV & nOPV2 campaigns in VRF + supplychain & vaccine stock vaccine filters

How to test

Create a campaign with a nOPV2 & bOPV scope
Add a sub-activity with mOPV

Go to supplychain
create a VRF for the campaign: the vaccine dropdown should show all 3 vaccines

Check supplychain and vaccine stock vaccine filters: "nOPV2 & bOPV" should not appear (only individual vaccines)

Print screen / video

Uploading Screen Recording 2024-12-19 at 14.46.17.mov…

Notes

merges in to POLIO-1762-nOPV2-bOPV-cVDPV2-cVDPV3

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@beygorghor beygorghor merged commit 53e0369 into POLIO-1762-nOPV2-bOPV-cVDPV2-cVDPV3 Dec 19, 2024
3 checks passed
@beygorghor beygorghor deleted the POLIO-1803_adapt_suppplychain_to_bopv_nopv_new_vaccine branch December 19, 2024 14:10
@beygorghor beygorghor added the user tested Has already been tested on staging label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user tested Has already been tested on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants