Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLIO-1791: update front-end subactivities #1865

Open
wants to merge 2 commits into
base: POLIO-1790_add_lqas_im_to_subactivity_model
Choose a base branch
from

Conversation

quang-le
Copy link
Member

Add fields added in POLIO-1790 in front-end form

Related JIRA tickets : POLIO-1791

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

Explain the changes that were made.

  • Add lqas/im fields to list API response
  • Add fields in SubActivityForm
  • Update formik state with new fields
  • Update TS type
  • Add validation for LQAS/IM fields
  • Add translations

How to test

  • Create a Subactivity
  • LQAS/IM fields should be visible
  • Add dates and save
  • Open subactivity
  • Saved values should be displayed
  • Try to add wrong dates: end date before start date or LQAS/IM start datre before subactivity end date: fields should be in error

Print screen / video

Screen.Recording.2024-12-11.at.16.45.55.mov

Notes

Merges in POLIO-1790

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

quang-le and others added 2 commits December 11, 2024 16:38
- Add fields in SubActivityForm
- Update formik state with new fields
- Update TS type
- Add validation for LQAS/IM fields
- Add translations

Co-authored-by: fleury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant