WC2-523 Add storage logs to bulk update #1857
Open
+166
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA tickets : https://bluesquare.atlassian.net/browse/WC2-523
Why?
Now that we use the bulk upload on WFP, what happens is (in this order):
Since the first step is executed in an async job, the entity is sometimes not yet created when request 2 hits the server.
The solution is to add the storage logs to the bulk upload zip so it's processed as part of the bulk upload.
How to test?
Difficult... Honestly I'd say if the code looks reasonable, we deploy to QA and test with a new apk that adds the storage logs correctly.