-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POLIO-1770, POLIO-1768: delete unused scopes + migration #1837
Merged
quang-le
merged 9 commits into
POLIO-1753_split_pdf_data_per_vaccine_per_round
from
POLIO-1770_delete_unused_scopes
Dec 2, 2024
Merged
POLIO-1770, POLIO-1768: delete unused scopes + migration #1837
quang-le
merged 9 commits into
POLIO-1753_split_pdf_data_per_vaccine_per_round
from
POLIO-1770_delete_unused_scopes
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if separate scopes per round: delete campaign scope - else: delete round scopes
- delete unused scopes when switching scope type - only loop through used scope when updating
7 tasks
kemar
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The logic seems good and kudos for the test which helps to understand the code.
I suggest some simplifications to make the code easier to read. You're free to apply them or not.
Co-authored-by: Marc Hertzog <[email protected]>
Co-authored-by: Marc Hertzog <[email protected]>
Co-authored-by: Marc Hertzog <[email protected]>
quang-le
merged commit Dec 2, 2024
af7b7fe
into
POLIO-1753_split_pdf_data_per_vaccine_per_round
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving? Explain here in one sentence.
Related JIRA tickets : POLIO-1770, POLIO-1768
Self proofreading checklist
Doc
N/A
Changes
POLIO-1768: migration
POLIO-1770: update API
How to test
On polio DB:
--> The old scopes should have been removed from GET response, but will still be visible in front-end because of formik state. Reloading the page will make it diappear
Print screen / video
Uploading Screen Recording 2024-11-29 at 15.13.32.mov…
Notes
MERGES INTO #1830
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.