Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POLIO-1760 Remove round_one and round_two from the Campaign API payload #1831

Merged
merged 2 commits into from
Nov 27, 2024
Merged

POLIO-1760 Remove round_one and round_two from the Campaign API payload #1831

merged 2 commits into from
Nov 27, 2024

Conversation

kemar
Copy link
Member

@kemar kemar commented Nov 26, 2024 •
edited
Loading

Remove round_one and round_two from the Campaign API payload

Related JIRA tickets : POLIO-1760

Changes

  • Remove round_one and round_two from the Campaign's serializers
  • Clean frontend translations

@kemar kemar self-assigned this Nov 26, 2024
@kemar kemar marked this pull request as ready for review November 26, 2024 16:33
quang-le
quang-le reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@quang-le quang-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conventional commit !!! 😁

@kemar
Copy link
Member Author

kemar commented Nov 27, 2024

Conventional commit !!! 😁

Thanx for the reminder 🤣

@kemar kemar merged commit b1c55e4 into main Nov 27, 2024
6 checks passed
@kemar kemar deleted the POLIO-1760-clean-campaign-api branch November 27, 2024 10:23
@butofleury butofleury added the user tested Has already been tested on staging label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quang-le quang-le quang-le approved these changes

Assignees

@kemar kemar

Labels
Released user tested Has already been tested on staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kemar @quang-le @butofleury @hakifran