Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WC2-584: [Web] Duplicate pair details: visual improvements #1708

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

hakifran
Copy link
Contributor

@hakifran hakifran commented Oct 12, 2024

Explain what problem this PR is resolving

  • [Web] Duplicate pair details: visual improvements
    Related JIRA tickets : WC2-584

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

  • Tell us where the doc can be found (docs folder, wiki, in the code...)

Changes

  • Changed the label for ExpandableItem for submissions

How to test

  • Go to Beneficiaries ---> Duplicates ---> see details
  • Check the Submissions for Beneficiary A and Submissions for Beneficiary B order and appearance.

Print screen / video

Screencast.from.2024-10-12.13-21-19.webm

Notes

Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here

@hakifran hakifran requested a review from beygorghor October 12, 2024 11:23
@bramj bramj self-requested a review October 14, 2024 07:50
Copy link
Contributor

@bramj bramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @hakifran ! Looking good to me 👍

@hakifran hakifran merged commit ce589c4 into main Oct 15, 2024
5 checks passed
@hakifran hakifran deleted the WC2-584-Duplicate-pair-details-visual-improvements branch October 15, 2024 13:15
@quang-le quang-le added ok for release user tested Has already been tested on staging Released and removed ok for release labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released user tested Has already been tested on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants