Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-2996-IA-2949: Make Completeness table for PBF as a module as we can hide it and All search in french on modules #1348

Conversation

hakifran
Copy link
Contributor

@hakifran hakifran commented May 31, 2024

Explain what problem this PR is resolving

  • Make Completeness table for PBF as a module as we can hide it
  • Modules: text search only works with English module names
    Related JIRA tickets : IA-2996, IA-2949

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

  • Add new module with Completeness per Period as name and link iaso_completeness with it
  • Add fr_name key in modules to translate the module name and be able to search in french

How to test

  • Check on the modules page
  • Remove the new module from the account
  • Check if the iaso_completeness is still avaible in the permissions list
  • Search modules with french name

Print screen / video

@hakifran hakifran requested a review from beygorghor May 31, 2024 13:46
@hakifran hakifran merged commit 2f13c2b into main May 31, 2024
3 checks passed
@hakifran hakifran deleted the IA-2996-IA-2949-make-completeness-as-module-search-modules-on-french branch May 31, 2024 14:28
@kemar kemar added release Should be released in production at next deploy Released and removed release Should be released in production at next deploy labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants