Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-2753:Pictures of health facilities should look like real ones #1347

Conversation

butofleury
Copy link
Member

@butofleury butofleury commented May 31, 2024

Related JIRA tickets : IA-2753

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Replaced fake health facility images with real one when creating submissions!

How to test

From setuper folder, launch python3 setuper.py to create data and open submissions page on the file tab : http://localhost:8081/dashboard/forms/submissions/tab/files

You should see real health facility images!

Print screen / video

Real_health_facility_images.mp4

@butofleury butofleury changed the title Replace fake health facility image with real ones IA-2753:Pictures of health facilities should look like real ones May 31, 2024
@butofleury butofleury requested a review from beygorghor May 31, 2024 13:10
@madewulf madewulf added the release Should be released in production at next deploy label Jun 3, 2024
@kemar kemar removed the release Should be released in production at next deploy label Jun 4, 2024
@butofleury butofleury merged commit 9e52766 into main Jun 5, 2024
3 checks passed
@butofleury butofleury deleted the IA-2753-Pictures-of-health-facilities-should-look-like-real-ones branch June 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants