Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3004: Display a QRCode in the project configuration popup #1341

Merged
merged 1 commit into from
May 31, 2024

Conversation

bmonjoie
Copy link
Member

Display a QRCode in the project configuration popup

Related JIRA tickets : IA-3004

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • Are there enough tests

Doc

  • Documentation can be found in the code

Changes

This adds a small endpoint on /api/projects/<project_id>/ called qr_code which generates a QRCode with the following JSON inside:

{
  "url": "URL of the server",
  "app_id": "app_id of the project referred by id"
}

How to test

As a user with sufficient rights, go in the project configuration. When a project already exists, a QRCode should be showing on the first tab.

Print screen / video

image

@bmonjoie bmonjoie added the enhancement New feature or request label May 30, 2024
@bmonjoie bmonjoie requested review from kemar and beygorghor May 30, 2024 13:51
@bmonjoie bmonjoie self-assigned this May 30, 2024
Copy link
Member

@kemar kemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmonjoie bmonjoie merged commit 8423281 into main May 31, 2024
3 checks passed
@bmonjoie bmonjoie deleted the feat/IA-3004_configure_app_via_qrcode branch May 31, 2024 12:58
@kemar kemar added release Should be released in production at next deploy Released and removed release Should be released in production at next deploy labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants