-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polio-1556 sub activities front end #1340
Merged
quang-le
merged 11 commits into
POLIO-1540-create-new-tab-sub-activities-for-all-campaigns-polio-and-non-polio
from
POLIO-1556_sub_activities_front_end
Jun 3, 2024
Merged
Polio-1556 sub activities front end #1340
quang-le
merged 11 commits into
POLIO-1540-create-new-tab-sub-activities-for-all-campaigns-polio-and-non-polio
from
POLIO-1556_sub_activities_front_end
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tivities-for-all-campaigns-polio-and-non-polio' into POLIO-1556_sub_activities_front_end
- make baseUrl optional in useTabs - Add useTableState hook - export polio viruses - fix query key in useSaveCampaigns
- Pass campaign as prop i.o getting it via formik context - Add useFilteredDistricts hook to allow filtering on different scopes - Pass availableVaccines to scopes map to enable more flexible vaccine selection
- Add new components - update polio dialog tabs
quang-le
changed the base branch from
POLIO-1540-create-new-tab-sub-activities-for-all-campaigns-polio-and-non-polio
to
main
May 30, 2024 13:47
quang-le
changed the base branch from
main
to
POLIO-1540-create-new-tab-sub-activities-for-all-campaigns-polio-and-non-polio
May 30, 2024 13:47
- prevent modal from closing when clicking Confirm - Show spinner while mutation is performed - close modal onSuccess. This allows the mutation hook to invalidate the query key and make sure the data is refetched
beygorghor
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Very clean a few remarks:
- Can we add some min and max date using round date ?
- This filed is on error on focus, it should go on error while focu
- s, edited and emptied
- Space between inputs is too large:
- I have some inconsistency with scope round s and sub activities scopes:
https://github.com/BLSQ/iaso/assets/12494624/ebde03de-5db4-4cde-aed2-0bf3ebdbedbf
plugins/polio/js/src/domains/Campaigns/MainDialog/usePolioDialogTabs.tsx
Show resolved
Hide resolved
- fix spacing between input fields
beygorghor
approved these changes
Jun 3, 2024
quang-le
merged commit Jun 3, 2024
3b7c90e
into
POLIO-1540-create-new-tab-sub-activities-for-all-campaigns-polio-and-non-polio
3 checks passed
kemar
added
Released
and removed
release
Should be released in production at next deploy
labels
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new tab to polio
Related JIRA tickets : POLIO-1556
Self proofreading checklist
Doc
comments in the code
Changes
How to test
With a polio then a non-polio campaign:
Print screen / video
Screen.Recording.2024-05-30.at.15.40.32.mov
Notes
@mathvdh the sorting doens't seem to work. The params are sent to the API, but no sorting happens