IA-3024: Not displaying permissions related to modules which are not linked to the account

[hakifran]

Explain what problem this PR is resolving

• Not displaying permissions related to modules which are not linked to the account
  Related JIRA tickets : IA-3024

Self proofreading checklist

• Did I use eslint and black formatters
• Is my code clear enough and well documented
• Are my typescript files well typed
• New translations have been added or updated if new strings have been introduced in the frontend
• My migrations file are included
• Are there enough tests
• Documentation has been included (for new feature)

Changes

• Check if grouped permissions is empty and skip if it is

How to test

• Remove some modules from the current account
• Check if some permissions groups still appearing

Print screen / video

Screencast.from.2024-05-24.16-02-47.webm

[kemar]

LGTM
I have a few comments on the form that you can fix if you agree with them.

[kemar]

Suggested change

	permissions = perms.filter(codename__in=PERMISSIONS_PRESENTATION[group])
	if permissions:
	result[group] = []
	for permission in permissions:
	result[group].append(
	{"id": permission.id, "name": _(permission.name), "codename": permission.codename}
	)
	for permission in perms.filter(codename__in=PERMISSIONS_PRESENTATION[group]):
	result[group] = []
	result[group].append({"id": permission.id, "name": _(permission.name), "codename": permission.codename})

I think you can keep the previous code and just move the result[group] = [] line inside the for loop.

This could save a bunch of statements.

[hakifran]

But at each loop it will remove the previous added permission and at the end result[group] will have the last permission

[kemar]

Yes you're right!
But that's strange because I ran the unit tests with this modified code and they were successful 🤔

[hakifran]

self.assertTrue( set([permission["codename"] for permission in response.json()["permissions"]["org_units"]]) <= set(PERMISSIONS_PRESENTATION["org_units"]), ). Maybe I did it wrong here?