POLIO-1540 Create new tab sub activities for all campaigns polio and non polio #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tivities-for-all-campaigns-polio-and-non-polio' into POLIO-1556_sub_activities_front_end
quang-le
reviewed
May 28, 2024
There was a problem hiding this comment.
I tried the POST and PUT in the front-end, it works fine, but shouldn't we check the values against those of the round? eg:
- start and end date should be within the round dates
- scope should be a subset of round scopes
- vaccines should be a subset of round vaccines
| class SubActivityCreateUpdateSerializer(serializers.ModelSerializer): | ||
| round_number = serializers.IntegerField(write_only=True, required=False) | ||
| campaign = serializers.CharField(write_only=True, required=False) | ||
| scopes = SubActivityScopeSerializer(many=True, required=False) |
There was a problem hiding this comment.
shouldn't the scopes be mandatory?
There was a problem hiding this comment.
I think not, you could have first just the encoding of dates and reason of activity and the scope coming later
- make baseUrl optional in useTabs - Add useTableState hook - export polio viruses - fix query key in useSaveCampaigns
- Pass campaign as prop i.o getting it via formik context - Add useFilteredDistricts hook to allow filtering on different scopes - Pass availableVaccines to scopes map to enable more flexible vaccine selection
- Add new components - update polio dialog tabs
…-all-campaigns-polio-and-non-polio
- prevent modal from closing when clicking Confirm - Show spinner while mutation is performed - close modal onSuccess. This allows the mutation hook to invalidate the query key and make sure the data is refetched
- fix spacing between input fields
Polio-1556 sub activities front end
madewulf
approved these changes
Jun 4, 2024
madewulf
deleted the
POLIO-1540-create-new-tab-sub-activities-for-all-campaigns-polio-and-non-polio
branch
kemar
added
Released
and removed
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce SubActivity Model in Polio Plugin and the related APIs
Related JIRA tickets : POLIO-1540
Self proofreading checklist
Doc
In the
docs/pages/dev/campaigns/subactivities.mdfile included in this PR.Changes
SubActivitywhich represents a sub-activity within a round of a campaign. It has fields for name, age unit, minimum age, maximum age, start date, and end date.SubActivityScopemodel to represent the scope of a SubActivity with respect to vaccines.SubActivitymodel is linked to theRoundmodel via a foreign key, allowing each round to have multiple sub-activities.SubActivityScopemodel is linked to theSubActivitymodel via a foreign key, allowing each sub-activity to have multiple scopes.How to test
As this only includes the APIs and no frontend code, you can use /swagger to test and/or use django admin.