-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POLIO-1753: split pdf repository data per vaccine per round #1830
Merged
quang-le
merged 25 commits into
main
from
POLIO-1753_split_pdf_data_per_vaccine_per_round
Dec 3, 2024
Merged
POLIO-1753: split pdf repository data per vaccine per round #1830
quang-le
merged 25 commits into
main
from
POLIO-1753_split_pdf_data_per_vaccine_per_round
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- i.o 1 line per round, with vaccines aggegated
- add PolioTestCaseMixin+method to create campaign test data - add method to add base test data: account, source, user
- rename round_number field to number - move filters to get_queryset to avoid errors due to union queryset - fix and add tests
…ps://github.com/BLSQ/iaso into POLIO-1753_split_pdf_data_per_vaccine_per_round
I put it back to draft status because the file filter is now buggy, but the rest can already be reviewed |
- if separate scopes per round: delete campaign scope - else: delete round scopes
- delete unused scopes when switching scope type - only loop through used scope when updating
7 tasks
Co-authored-by: Marc Hertzog <[email protected]>
Co-authored-by: Marc Hertzog <[email protected]>
Co-authored-by: Marc Hertzog <[email protected]>
7 tasks
kemar
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Marc Hertzog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
postrelease
Should be merged just after the release
Released
user tested
Has already been tested on staging
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rounds can have several vaccines. The pdf table in the repository should reflect that and have one line per round per vaccine
Related JIRA tickets : POLIO-1753
Self proofreading checklist
Doc
Comments in the code
Changes
get_queryset
method ofVaccineRepositoryViewSet
to return a union of therounds_queryset
filtered by each vaccine (so: 1 queryset with all rounds with nopv2, 1 for mopv2 and 1 for nopv), so that rounds with multiple vaccines are duplicated.get_queryset
because.filter()
cannot be called on a union querysetHow to test
On a recent polio test DB:
Print screen / video
Notes
Merges in to #1822
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.