Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IA-3484: Eslint #1679

Merged
merged 9 commits into from
Oct 4, 2024
Merged

IA-3484: Eslint #1679

merged 9 commits into from
Oct 4, 2024

Conversation

beygorghor
Copy link
Collaborator

@beygorghor beygorghor commented Oct 3, 2024 •
edited
Loading

We have now more than 2500 error on eslint

Related JIRA tickets : IA-3484

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

  • change rules
  • fix small errors

How to test

Everything should work like before

Screenshot 2024-10-03 at 15 30 22

@beygorghor
Copy link
Collaborator Author

Cypress ✅ => https://github.com/BLSQ/iaso/actions/runs/11163723233

@quang-le quang-le added the release Should be released in production at next deploy label Oct 4, 2024
quang-le
quang-le approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@quang-le quang-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@beygorghor beygorghor merged commit f1dcc22 into main Oct 4, 2024
3 checks passed
@beygorghor beygorghor deleted the ESLINT-RULES branch October 4, 2024 08:58
@kemar kemar added Released and removed release Should be released in production at next deploy labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quang-le quang-le quang-le approved these changes

Assignees
No one assigned
Labels
Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beygorghor @quang-le @kemar