Merge pull request #1679 from BLSQ/ESLINT-RULES

IA-3484: Eslint
BLSQ · Oct 4, 2024 · f1dcc22 · f1dcc22
2 parents 7673357 + 6680887
commit f1dcc22
Show file tree

Hide file tree

Showing 416 changed files with 1,910 additions and 2,491 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/hat/assets/js/apps/Iaso/components/Cells/BreakWordCell.tsx b/hat/assets/js/apps/Iaso/components/Cells/BreakWordCell.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable camelcase */
 import { Box } from '@mui/material';
 import React, { ReactElement } from 'react';
 import { makeStyles } from '@mui/styles';

diff --git a/hat/assets/js/apps/Iaso/components/Cells/DateTimeCell.tsx b/hat/assets/js/apps/Iaso/components/Cells/DateTimeCell.tsx
@@ -9,8 +9,9 @@ import { apiDateFormats } from '../../utils/dates';
 /* DateTimeCell
    For use in Table's columns to display DateTime
  */
-export const DateTimeCell = (cellInfo: { value?: number | null }): string =>
-    displayDateFromTimestamp(cellInfo?.value);
+export const DateTimeCell = (cellInfo: {
+    value?: number | null | undefined;
+}): string => displayDateFromTimestamp(cellInfo?.value);
 
 export const convertToDateTimeRfc = (
     value: string | null | undefined,

diff --git a/hat/assets/js/apps/Iaso/components/Cells/UserCell.tsx b/hat/assets/js/apps/Iaso/components/Cells/UserCell.tsx
@@ -1,8 +1,7 @@
-/* eslint-disable camelcase */
 import React, { ReactElement } from 'react';
 import getDisplayName, { User } from '../../utils/usersUtils';
 
 export const UserCell = (cellInfo: { value?: Partial<User> }): ReactElement => {
     const value = cellInfo?.value ?? '';
-    return <>{value ? getDisplayName(value) : '--'}</>;
+    return <span>{value ? getDisplayName(value) : '--'}</span>;
 };
diff --git a/hat/assets/js/apps/Iaso/components/FilterButton.tsx b/hat/assets/js/apps/Iaso/components/FilterButton.tsx
@@ -1,8 +1,6 @@
-/* eslint-disable react/require-default-props */
-/* eslint-disable react/jsx-props-no-spreading */
-import React, { FunctionComponent } from 'react';
 import FiltersIcon from '@mui/icons-material/FilterList';
-import { Button, Box } from '@mui/material';
+import { Box, Button } from '@mui/material';
+import React, { FunctionComponent } from 'react';
 import { FormattedMessage, defineMessages } from 'react-intl';
 
 const MESSAGES = defineMessages({

diff --git a/hat/assets/js/apps/Iaso/components/LegendBuilder/LegendBuilderDialog.tsx b/hat/assets/js/apps/Iaso/components/LegendBuilder/LegendBuilderDialog.tsx
@@ -1,27 +1,25 @@
-/* eslint-disable camelcase */
-import React, { FunctionComponent, useCallback, useMemo } from 'react';
+import { Box, Button } from '@mui/material';
 import {
+    ConfirmCancelModal,
     IntlMessage,
     makeFullModal,
-    ConfirmCancelModal,
     useSafeIntl,
 } from 'bluesquare-components';
+import React, { FunctionComponent, useCallback, useMemo } from 'react';
 import * as Yup from 'yup';
-import { Box, Button } from '@mui/material';
 
-import { useFormik } from 'formik';
 import Add from '@mui/icons-material/Add';
+import { useFormik } from 'formik';
+import { EditIconButton } from '../Buttons/EditIconButton';
+import { LegendBuilder } from './index';
 import { MESSAGES } from './messages';
 import { ScaleThreshold } from './types';
-import { LegendBuilder } from './index';
 import { getRangeValues, getScaleThreshold } from './utils';
-import { EditIconButton } from '../Buttons/EditIconButton';
 
 type Props = {
     titleMessage: IntlMessage;
     isOpen: boolean;
     closeDialog: () => void;
-    // eslint-disable-next-line no-unused-vars
     onConfirm: (threshold?: ScaleThreshold) => void;
     threshold?: ScaleThreshold;
 };

diff --git a/hat/assets/js/apps/Iaso/components/LegendBuilder/LegendRange.tsx b/hat/assets/js/apps/Iaso/components/LegendBuilder/LegendRange.tsx
@@ -1,11 +1,11 @@
-import React, { FunctionComponent } from 'react';
-import { IconButton, Grid, Typography, Box } from '@mui/material';
-import { makeStyles } from '@mui/styles';
 import RemoveIcon from '@mui/icons-material/Remove';
+import { Box, Grid, IconButton, Typography } from '@mui/material';
+import { makeStyles } from '@mui/styles';
+import React, { FunctionComponent } from 'react';
 import { ColorPicker } from '../forms/ColorPicker';
 import InputComponent from '../forms/InputComponent';
-import { RangeValue } from './types';
 import { legendColors } from './colors';
+import { RangeValue } from './types';
 
 const useStyles = makeStyles(theme => ({
     legendItem: {
@@ -23,13 +23,9 @@ type LegendRowProps = {
     rangeItem: RangeValue;
     index: number;
     rangeValues: RangeValue[];
-    // eslint-disable-next-line no-unused-vars
     handleColorChange: (index: number) => void;
-    // eslint-disable-next-line no-unused-vars
     handleNumberChange: (index: number, newNumber?: number) => void;
-    // eslint-disable-next-line no-unused-vars
     removeRangeValue: (index: number) => void;
-    // eslint-disable-next-line no-unused-vars
     setFieldError: (keyValue: string, message: string) => void;
     errors?: string[];
 };

diff --git a/hat/assets/js/apps/Iaso/components/LegendBuilder/index.tsx b/hat/assets/js/apps/Iaso/components/LegendBuilder/index.tsx
@@ -1,11 +1,11 @@
-import React, { FunctionComponent, useCallback } from 'react';
+import AddIcon from '@mui/icons-material/Add';
 import { Box, IconButton } from '@mui/material';
 import { makeStyles } from '@mui/styles';
-import AddIcon from '@mui/icons-material/Add';
+import React, { FunctionComponent, useCallback } from 'react';
 
+import { legendColors } from './colors';
 import { LegendRange } from './LegendRange';
 import { RangeValue } from './types';
-import { legendColors } from './colors';
 
 const useStyles = makeStyles(theme => ({
     root: {
@@ -36,9 +36,7 @@ const useStyles = makeStyles(theme => ({
 
 type LegendBuilderProps = {
     rangeValues: RangeValue[];
-    // eslint-disable-next-line no-unused-vars
     onChange: (newRangeValues: RangeValue[]) => void;
-    // eslint-disable-next-line no-unused-vars
     setFieldError: (keyValue: string, message: string) => void;
     errors?: string[];
 };

diff --git a/hat/assets/js/apps/Iaso/components/dialogs/ConfirmCancelDialogComponent.js b/hat/assets/js/apps/Iaso/components/dialogs/ConfirmCancelDialogComponent.js
@@ -45,21 +45,23 @@ function RawConfirmCancelActions({
             >
                 <FormattedMessage {...confirmMessage} />
             </Button>
-            {additionalButton && additionalMessage && onAdditionalButtonClick && (
-                <Button
-                    data-test="additional-button"
-                    onClick={() => onAdditionalButtonClick(closeDialog)}
-                    color="primary"
-                    disabled={
-                        allowConfimAdditionalButton !== null &&
-                        allowConfimAdditionalButton !== undefined
-                            ? !allowConfimAdditionalButton
-                            : !allowConfirm
-                    }
-                >
-                    <FormattedMessage {...additionalMessage} />
-                </Button>
-            )}
+            {additionalButton &&
+                additionalMessage &&
+                onAdditionalButtonClick && (
+                    <Button
+                        data-test="additional-button"
+                        onClick={() => onAdditionalButtonClick(closeDialog)}
+                        color="primary"
+                        disabled={
+                            allowConfimAdditionalButton !== null &&
+                            allowConfimAdditionalButton !== undefined
+                                ? !allowConfimAdditionalButton
+                                : !allowConfirm
+                        }
+                    >
+                        <FormattedMessage {...additionalMessage} />
+                    </Button>
+                )}
         </DialogActions>
     );
 }

diff --git a/hat/assets/js/apps/Iaso/components/dialogs/DialogComponent.js b/hat/assets/js/apps/Iaso/components/dialogs/DialogComponent.js
@@ -26,7 +26,6 @@ const normalizedMessage = CompOrMessage => {
         return '';
     }
     if (CompOrMessage.id) {
-        // eslint-disable-next-line react/jsx-props-no-spreading
         return <FormattedMessage {...CompOrMessage} />;
     }
     return CompOrMessage;

diff --git a/hat/assets/js/apps/Iaso/components/dialogs/ImageGalleryComponent.tsx b/hat/assets/js/apps/Iaso/components/dialogs/ImageGalleryComponent.tsx
@@ -105,11 +105,9 @@ type Props = {
     closeLightbox: () => void;
     imageList: ShortFile[];
     currentIndex: number;
-    // eslint-disable-next-line no-unused-vars
     setCurrentIndex?: (index: number) => void;
     url?: string | null;
     urlLabel?: { id: string; defaultMessage: string } | undefined;
-    // eslint-disable-next-line no-unused-vars
     getExtraInfos?: (image: ShortFile) => React.ReactNode;
 };
 

diff --git a/hat/assets/js/apps/Iaso/components/errors/PageNoPerms.tsx b/hat/assets/js/apps/Iaso/components/errors/PageNoPerms.tsx
@@ -1,10 +1,9 @@
-/* eslint-disable react/jsx-props-no-spreading */
-import React from 'react';
-import { FormattedMessage } from 'react-intl';
+import Info from '@mui/icons-material/Info';
 import { Box, Container, Paper, Typography } from '@mui/material';
 import { makeStyles } from '@mui/styles';
-import Info from '@mui/icons-material/Info';
 import { ClassNameMap } from 'notistack';
+import React from 'react';
+import { FormattedMessage } from 'react-intl';
 import TopBar from '../nav/TopBarComponent';
 
 import MESSAGES from './messages';

diff --git a/hat/assets/js/apps/Iaso/components/files/FavButton.tsx b/hat/assets/js/apps/Iaso/components/files/FavButton.tsx
@@ -31,9 +31,7 @@ const MESSAGES = defineMessages({
 
 type Props = {
     file: ShortFile;
-    // eslint-disable-next-line no-unused-vars
     onImageFavoriteClick: (id: number) => void;
-    // eslint-disable-next-line no-unused-vars
     isDefaultImage: (id: number) => boolean;
 };
 

diff --git a/hat/assets/js/apps/Iaso/components/files/LazyImagesListComponent.tsx b/hat/assets/js/apps/Iaso/components/files/LazyImagesListComponent.tsx
@@ -26,11 +26,8 @@ const styles = {
 
 type Props = {
     imageList: ShortFile[];
-    // eslint-disable-next-line no-unused-vars
     onImageClick: (index: number) => void;
-    // eslint-disable-next-line no-unused-vars
     onImageFavoriteClick?: (id: number) => void;
-    // eslint-disable-next-line no-unused-vars
     isDefaultImage?: (id: number) => boolean;
 };
 

diff --git a/hat/assets/js/apps/Iaso/components/filters/DatesRange.d.ts b/hat/assets/js/apps/Iaso/components/filters/DatesRange.d.ts
@@ -4,7 +4,6 @@ import { ComponentType } from 'react';
 interface DatesRangeProps {
     dateFrom?: string;
     dateTo?: string;
-    // eslint-disable-next-line no-unused-vars
     onChangeDate: (key: string, value: any) => void;
     labelTo?: { id: string; defaultMessage: string };
     labelFrom?: { id: string; defaultMessage: string };

diff --git a/hat/assets/js/apps/Iaso/components/forms/AsyncSelect.tsx b/hat/assets/js/apps/Iaso/components/forms/AsyncSelect.tsx
@@ -1,15 +1,15 @@
-import React, { FunctionComponent, useEffect, useMemo, useState } from 'react';
-import { defineMessages } from 'react-intl';
-import { debounce } from '@mui/material/utils';
+import { Box, TextField } from '@mui/material';
 import Autocomplete from '@mui/material/Autocomplete';
+import { AutocompleteGetTagProps } from '@mui/material/Autocomplete/Autocomplete';
+import { debounce } from '@mui/material/utils';
 import {
     IntlMessage,
     renderTags as defaultRenderTags,
     useSafeIntl,
 } from 'bluesquare-components';
-import { Box, TextField } from '@mui/material';
 import { isArray } from 'lodash';
-import { AutocompleteGetTagProps } from '@mui/material/Autocomplete/Autocomplete';
+import React, { FunctionComponent, useEffect, useMemo, useState } from 'react';
+import { defineMessages } from 'react-intl';
 
 const MESSAGES = defineMessages({
     noOptionsText: {
@@ -24,7 +24,6 @@ type Props = {
     loading?: boolean;
     loadingText?: IntlMessage;
     keyValue: string;
-    // eslint-disable-next-line no-unused-vars
     onChange: (keyValue, newValue: any | null) => void;
     errors?: string[];
     required?: boolean;
@@ -34,12 +33,9 @@ type Props = {
     multi?: boolean;
     helperText?: string;
     minCharBeforeQuery?: number;
-    // eslint-disable-next-line no-unused-vars
     fetchOptions: (input: string) => Promise<any[]>;
     renderTags?: (
-        // eslint-disable-next-line no-unused-vars
         tag: any[],
-        // eslint-disable-next-line no-unused-vars
         getTagProps: AutocompleteGetTagProps,
     ) => React.ReactNode;
 };
@@ -94,7 +90,6 @@ export const AsyncSelect: FunctionComponent<Props> = ({
             debounce(
                 (
                     request: { input: string },
-                    // eslint-disable-next-line no-unused-vars
                     callback: (results?: readonly any[]) => void,
                 ) => {
                     setLoading(true);
@@ -139,7 +134,6 @@ export const AsyncSelect: FunctionComponent<Props> = ({
                 id={keyValue}
                 renderInput={params => (
                     <TextField
-                        /* eslint-disable-next-line react/jsx-props-no-spreading */
                         {...params}
                         id={keyValue}
                         disabled={disabled}

diff --git a/hat/assets/js/apps/Iaso/components/forms/InputComponent.tsx b/hat/assets/js/apps/Iaso/components/forms/InputComponent.tsx
@@ -61,8 +61,7 @@ export type InputComponentProps = {
     keyValue: string;
     value?: any;
     errors?: string[];
-    onChange?: // eslint-disable-next-line no-unused-vars
-    (key: string, value: any, countryData?: BaseCountryData) => void;
+    onChange?: (key: string, value: any, countryData?: BaseCountryData) => void;
 
     options?: any[];
     disabled?: boolean;
@@ -76,26 +75,17 @@ export type InputComponentProps = {
     multi?: boolean;
     uid?: string;
     loading?: boolean;
-    // eslint-disable-next-line no-unused-vars
     getOptionLabel?: (option: Option) => string;
-    getOptionSelected?: (
-        // eslint-disable-next-line no-unused-vars
-        option: Option,
-        // eslint-disable-next-line no-unused-vars
-        value: Option,
-    ) => boolean;
+    getOptionSelected?: (option: Option, value: Option) => boolean;
     renderOption?: (
-        // eslint-disable-next-line no-unused-vars
         option: Option,
-        // eslint-disable-next-line no-unused-vars
         { inputValue }: { inputValue: string },
     ) => ReactNode;
     className?: string;
     helperText?: string;
     min?: number;
     max?: number;
     blockForbiddenChars?: boolean;
-    // eslint-disable-next-line no-unused-vars
     onErrorChange?: (hasError: boolean) => void;
     numberInputOptions?: {
         prefix?: string;
@@ -107,10 +97,8 @@ export type InputComponentProps = {
         thousandSeparator?: '.' | ',';
     };
     phoneInputOptions?: PhoneInputOptions;
-    // eslint-disable-next-line no-unused-vars
     setFieldError?: (keyValue: string, message: string) => void;
     autoComplete?: string;
-    // eslint-disable-next-line no-unused-vars
     renderTags?: (tagValue: Array<any>, getTagProps: any) => Array<any>;
     freeSolo?: boolean; // this props i only use on single select and allow user to give an option not present in the list. Errors will be ignored
     returnFullObject?: boolean;
@@ -240,7 +228,6 @@ const InputComponent: React.FC<InputComponentProps> = ({
                         }}
                         setFieldError={setFieldError}
                         dataTestId={dataTestId}
-                        // eslint-disable-next-line react/jsx-props-no-spreading
                         {...localizedNumberOptions}
                     />
                 );
@@ -334,7 +321,6 @@ const InputComponent: React.FC<InputComponentProps> = ({
                         lang={locale as LangOptions}
                         required={required}
                         disabled={disabled}
-                        // eslint-disable-next-line react/jsx-props-no-spreading
                         {...phoneInputOptions}
                     />
                 );

diff --git a/hat/assets/js/apps/Iaso/components/forms/TextArea.tsx b/hat/assets/js/apps/Iaso/components/forms/TextArea.tsx
@@ -1,20 +1,19 @@
 import React, { FunctionComponent, useEffect, useRef, useState } from 'react';
 
+import { FormHelperText, InputLabel } from '@mui/material';
+import { makeStyles } from '@mui/styles';
 import {
     FormControl,
     commonStyles,
     useSkipEffectOnMount,
 } from 'bluesquare-components';
 import classnames from 'classnames';
-import { InputLabel, FormHelperText } from '@mui/material';
-import { makeStyles } from '@mui/styles';
 import { useDebounce } from 'use-debounce';
 import { Optional } from '../../types/utils';
 
 type Props = {
     value?: string;
     label: string;
-    // eslint-disable-next-line no-unused-vars
     onChange: (newValue: string) => void;
     errors?: string[];
     required?: boolean;