Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ods.yaml structure #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

michaelsauter
Copy link
Contributor

No description provided.

@michaelsauter michaelsauter requested a review from velcrin March 5, 2024 08:23
@michaelsauter michaelsauter self-assigned this Mar 5, 2024
- name: dev
namespace: {{cookiecutter.__project_slug}}-dev
stage: dev

pipeline:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be pipelines?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for the others

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is just one target namespace, it is not needed. If there are different targets based on different branches, then pipeline triggers would be used, as explained in https://github.com/opendevstack/ods-pipeline/blob/main/docs/ods-configuration.adoc#configuring-pipeline-triggers. Would you add that as an example here? I thought to keep it super simple initially.

Copy link

@velcrin velcrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment otherwise LGTM

- name: dev
namespace: {{cookiecutter.__project_slug}}-dev
stage: dev

pipeline:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants