-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ods.yaml structure #1
base: main
Are you sure you want to change the base?
Conversation
- name: dev | ||
namespace: {{cookiecutter.__project_slug}}-dev | ||
stage: dev | ||
|
||
pipeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be pipelines
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes for the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is just one target namespace, it is not needed. If there are different targets based on different branches, then pipeline triggers would be used, as explained in https://github.com/opendevstack/ods-pipeline/blob/main/docs/ods-configuration.adoc#configuring-pipeline-triggers. Would you add that as an example here? I thought to keep it super simple initially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment otherwise LGTM
- name: dev | ||
namespace: {{cookiecutter.__project_slug}}-dev | ||
stage: dev | ||
|
||
pipeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes for the others
No description provided.