Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

740 update to new teaser use conditions and add new building elements #741

Draft
wants to merge 19 commits into
base: development
Choose a base branch
from

Conversation

DaJansenGit
Copy link
Member

@DaJansenGit DaJansenGit commented Oct 28, 2024

Before we can merge this, we need to

  • merge Use pyproject.toml for everything and update test resources problem #732 to include the new test resources strategy
  • merge dev into main and create a release. This is needed as the changes here will change the results of the simulations and we want to link a release with the current results in our paper
  • update the templates in the new test resources repository to add the new attributes and add "version" entry in all templates
  • Adjust the main plugin comfort templates that stay in the base repository.
    • cleanup comfort assets (move to test resources)
    • rename version 0.7 to TEASER-0.7
    • add new lighting parameters to comfort use conditions
  • update reference results if we want to have the maintained_illuminance calculation as default (which I suggest due to much more realistic internal loads through lights)

Changes

  • Thanks first to @HoeppJ for doing most of the changes. I needed to move them here to a fresh branch as there was some mixups with changes that are only related to your MA thesis.
  • we now have updated use conditions with dynamic option to use use more realistic lighting power with the option to change the lighting efficiency (use LED efficiency instead old values that are all based on old lighting hardware with much higher consumption and therefore internal loads)
  • support for newer building standards with KFW support
    • as for KFW we are not using building year, we can directly specify which type, e.g. by construction_class_walls= kfw_40
  • next to IWU and KFW we also now have the tabula data building element data in bim2sim
  • ...

This closes #740

@DaJansenGit DaJansenGit linked an issue Oct 28, 2024 that may be closed by this pull request
@DaJansenGit DaJansenGit self-assigned this Oct 28, 2024
@DaJansenGit
Copy link
Member Author

Mir ist bei den Änderungen folgendes noch aufgefallen:

  • lighting_power, bzw. jetzt fixed_lighting_power war für die Living use condition auf 7.0 statt 10.0 W/m² eingetragen beim file UseConditionsAC20-FZK-Haus.json. Dadurch würden sich die regression results ohnehin ändern, auch wenn
    use_maintained_illuminance nicht genutzt würde
  • Multiple use conditions files for DigitalHub:
    • UseConditionsFM_ARC_DigitalHub_fixed002.json
    • UseConditionsFM_ARC_DigitalHub_with_SB89.json
    • UseConditionsFM_ARC_DigitalHub_with_SB_neu.json
    • Only one difference between the three files: cooling_profile for "Kitchen in non-residential buildings" during day is 297.15 K for with_SB89 and 294.15 K for the other two files.

--> As activating the use_maintained_illuminance will change reference results anyway, I deleted the redundant use conditions files for digital hub as the only changes between the files are SBs and space names there is no reason to have different use conditiosn files. Only customUsages files make sense. The new file UseConditionsFM_ARC_DigitalHub.json uses 297.15 K as we won't cool a residential kitchen with 300 W/m² due to internal load of machines to 21 °C.

@DaJansenGit DaJansenGit changed the title 740 update to new teaser use conditions 740 update to new teaser use conditions and add new building elements Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to new teaser use conditions
2 participants