Profile UI for CCE Minor Experiences. #1293
Conversation
…ts into CCEminorTabs
…ts into CCEMinorTabs
…ts into CCEMinorTabs
…lts into CCEMinorTabs
… forms. Also implemented an 'Edt' and 'Withdraw' functionality for both forms.
There was a problem hiding this comment.
- No text in phone number field
- Supervisor phone and email should not be required
- Required fields should have the red * (we have that style from somewhere else)
- Summer experience should connect through the IndividualRequirement table for the minor. See: Admin minor management page
- No big duplicate chunks for read-only vs edit
- Use jquery everywhere instead of vanilla javascript
app/__init__.py
Outdated
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| app.run() |
There was a problem hiding this comment.
None of this is necessary in init.py
app/controllers/minor/routes.py
Outdated
|
|
||
|
|
||
| @minor_bp.route('/cceMinor/<username>/viewProposal', methods=['GET']) | ||
| def viewProposal(username): |
There was a problem hiding this comment.
This route duplicates the already existing page.
app/models/summerExperience.py
Outdated
| summerYear = CharField() | ||
| roleDescription = TextField() | ||
| experienceType = CharField() | ||
| CceMinorContentArea = TextField() # Store as comma-separated values or use a related table if needed |
There was a problem hiding this comment.
This name is weird, because all summer experiences are part of the CCE Minor (also don't capitalize variables, and it should be plural). let's just go with contentAreas
app/models/summerExperience.py
Outdated
| supervisorName = CharField() | ||
| supervisorPhone = CharField() | ||
| supervisorEmail = CharField() | ||
| created_at = DateTimeField(default=datetime.datetime.now) |
There was a problem hiding this comment.
createdOn, for consistency
app/models/summerExperience.py
Outdated
| created_at = DateTimeField(default=datetime.datetime.now) | ||
|
|
||
| class Meta: | ||
| db_table = 'summerExperience' |
There was a problem hiding this comment.
Not necessary to have this meta class, since we are creating the table (and it isn't consistent naming with our other tables)
app/templates/base.html
Outdated
| <script src="https://code.jquery.com/ui/1.12.1/jquery-ui.js"></script> | ||
| <link rel="stylesheet" href="//code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css"> | ||
| <script src="https://code.jquery.com/jquery-3.6.0.min.js"></script> | ||
| <script src="https://code.jquery.com/ui/1.12.1/jquery-ui.js"></script> |
There was a problem hiding this comment.
You include jquery and jquery ui twice, even though they are already included. Also, stylesheets don't go in the scripts block (and are already included anyway).
app/logic/minor.py
Outdated
| other_experience_description = form_data.get('otherExperienceDescription', '') | ||
| if not other_experience_description: | ||
| raise ValueError("Other experience description is required.") | ||
| experience_type = other_experience_description |
There was a problem hiding this comment.
Let's just assign experience_type above, and not use an additional variable.
|
|
||
|
|
||
| @minor_bp.route('/cceMinor/<username>/updateSummerExperience', methods=['GET', 'POST']) | ||
| def updateSummerExperience(username): |
There was a problem hiding this comment.
Update and create need to be combined or otherwise share functionality
app/templates/minor/profile.html
Outdated
|
|
||
| <div class="form-group"> | ||
| <label for="experienceHoursOver300"><strong>Will your experience include at least 300 hours of work over the span of at least 8 weeks?</strong></label><br> | ||
| <input type="radio" id="yes300hours" name="experienceHoursOver300" value="Yes" {% if summer_experience.experienceHoursOver300 %}checked{% endif %} onclick="toggleTextarea()"> |
There was a problem hiding this comment.
We have already added a listener to these inputs, so we don't need to put an onclick in the html
Completed the backend for both Summer Experience and Other Engagement forms. Also implemented an 'Edt' and 'Withdraw' functionality for both forms.
Fixing issue #1152