-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Student admin #1063
base: development
Are you sure you want to change the base?
Student admin #1063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-evaluate all of the boolean expressions you have added this to. So far all of them are wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to create tests for new logic.
<div class="col-md-6 mb-3"> | ||
<div> | ||
{{createInputsButtons("searchCeltsAdminInput", "Add Celts Admin")}}<br> | ||
{% if g.current_user.isCeltsAdmin and not g.current_user.isCeltsStudentAdmin %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everyone with isCeltsAdmin
true will have isCeltsStudentAdmin
false, right? So Anderson was right after all, that the second part is redundant.
…lts into studentAdmin
…lts into studentAdmin
else: | ||
return Program.select().join(ProgramManager).where(ProgramManager.user==currentUser).order_by(Program.programName) | ||
|
||
|
||
|
||
def getAllowedTemplates(currentUser): | ||
"""Returns a list of all visible templates depending on who the current user is. If they are not an admin it should always be none.""" | ||
if currentUser.isCeltsAdmin: | ||
if currentUser.isCeltsAdmin or currentUser.isCeltsStudentAdmin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this allow them to see Bonner events?
Placing on hold because we need to reevaluate what permissions student admins should be able to have. |
#1181 creating spreadsheet here |
Spreadsheet has been created, still waiting to hear back from @BrianRamsay on whether not the permissions are correct so we can finalize this PR. |
Did: fixes #984 and added a new role called student Admin. Student admin should have the same privileges as program managers for all programs aside from Bonner.
Test: