-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix WeldxFile doctest for asdf 3.0 #904
Conversation
LGTM as well. I do not get, why the notebook tests for Python 3.10 fail with an ImportError for WeldxFile. |
That one is kind of puzzling. I do see an error related to "quality_standard_demo":
It looks like the cookiecutter template here: https://github.com/BAMWelDX/quality-standard-template weldx/.github/workflows/pytest.yml Line 78 in bb213a7
but is lacking a _version file (perhaps something has changed in setuptools-scm that it's no longer generating a _version.py ?).The missing file appears to be preventing correct entry point loading for weldx which then leads to the ImportError for weldx. |
Thank you for the fix @braingram ! I haven't had time yet to look into the issue regarding the quality standard template I will try to follow up with what you already found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 96.46% 96.45% -0.02%
==========================================
Files 95 95
Lines 6287 6287
==========================================
- Hits 6065 6064 -1
- Misses 222 223 +1 ☔ View full report in Codecov by Sentry. |
I have updated the outdated build chain causing the issues BAMWelDX/quality-standard-template#20 Thanks again @braingram |
Changes
As mentioned in #903
A doctest is failing due to changes in asdf 3.0 (including removal of
BuiltinExtension
) that result in slight and otherwise inconsequential header differences.This PR expands the use of
...
in the doctest to allow the text matching to ignore these header differences.Checks
CHANGELOG.md
tests/
doc/