Fix scrambling bugs #104 #105
Conversation
kraigher
commented
Apr 6, 2024
kraigher
commented
- Ensures ScrambleTeams() is not automatically called if IsScrambleEnabled is False
- Fix almost scamble message to take roundsToScramble configuration into account.
- Fix admin team scramble only done on T-win and not if more than 3 rounds in a row have been won.
kraigher
force-pushed
the
fix_scrambling_bugs
branch
from
5155981 to
27b3dbb
Compare
There was a problem hiding this comment.
Thanks for your first contribution 🚀
Overall it looks good, just some styling tweaks.
Are you also able to provide evidence that it was tested with a server full of players before I make the release?
If not I can merge it and ask people to test it for you. I've created a branch called We send them the artifacts from the latest PR build.scramble-updates so you can just point it there and I'll ask one of the server owners running the plugin if they would like to test it out for us.
kraigher
force-pushed
the
fix_scrambling_bugs
branch
from
27b3dbb to
9fac625
Compare
|
@kraigher merge the latest master, fix your conflicts and I'll see about finding someone to test it 👍 |
- Ensures ScrambleTeams() is not automatically called if IsScrambleEnabled is False - Fix almost scamble message to take roundsToScramble configuration into account. - Fix admin team scramble only done on T-win and not if more than 3 rounds in a row have been won.
kraigher
force-pushed
the
fix_scrambling_bugs
branch
from
9fac625 to
be9895b
Compare
|
I rebased on master now |
|
I've bumped the version and asked people to test it to ensure it's good. Once we've got confirmation I'll merge the changes and make a release. https://canary.discord.com/channels/1160907911501991946/1187531929831096391/1226126922816163902 |
|
Great I will make a new PR after this is merged which implements the AutoTeamBalance flag described in #104 |
