Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Change from LESS to SASS (#71) #73

Merged
merged 4 commits into from
May 11, 2015
Merged

Conversation

xipasduarte
Copy link
Contributor

Resolving issue #71.
Added bootstrap-sass to bower.json and removed bootstrap.
Added gulp-sass to package.json and removed gulp-less.

Notes:

  • Work needs to be done in order to handle some of the @extend commands used to "import" styles from Bootstrap's classes into other elements. (The use of placeholders/mixins should be considered.)
  • There seems to be an issue with the Gulp task build:styles that I was unable to solve:
Job 2, 'gulp build:styles' terminated by signal SIGBUS (Misaligned address error)

@@ -11,7 +11,7 @@
"dependencies": {
"backbone": "~1.1.2",
"Backbone.validateAll": "*",
"bootstrap": "~3.2.0",
"bootstrap-sass": "~3.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give 3.3.4 a try. Should cause no major (or minor) headaches.

@goblindegook
Copy link
Member

+1 for Sass placeholders, I created issue #74 to address it.

I'll look into your build issue soon, otherwise everything looks good to go.

@goblindegook goblindegook merged commit 75477b9 into B3ST:master May 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants