Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maak het mogelijk om database user te specificeren voor de brmo-service docker container #2351

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

oscarporsius
Copy link
Contributor

Added Database user variables in the server.xml file to it is possible to specify a custom database name if needed. Also added these variables to the Docker compose file.

@mprins mprins changed the title Added DB_USER variables Maak het mogelijk om database user te specificeren voor de brmo-service docker container Jan 7, 2025
Copy link
Member

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kun je analoog aan #2342 ook deze opnemen in de docker/localhost.env , dan is ook gedocumenteerd dat het stuk gaat als je dit doet icm. een container op basis van ghcr.io/b3partners/brmo-service-db

@oscarporsius
Copy link
Contributor Author

Kun je analoog aan #2342 ook deze opnemen in de docker/localhost.env , dan is ook gedocumenteerd dat het stuk gaat als je dit doet icm. een container op basis van ghcr.io/b3partners/brmo-service-db

Ik heb de waardes in de localhost.env toegevoegd. Zie: ea09890

@mprins mprins merged commit 8911b2d into master Jan 13, 2025
31 checks passed
@mprins mprins deleted the parameters-for-docker-environment-vars branch January 13, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants