feat: Enforce keycloak UUIDs as user identifiers - take 2 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
einnhverr
force-pushed
the
feat-3869/uuid-columns
branch
2 times, most recently
from
e53a271 to
3c0853d
Compare
einnhverr
force-pushed
the
feat-3869/uuid-columns
branch
from
d93bee0 to
fd75f04
Compare
fbufler
approved these changes
Dec 17, 2024
Comment on lines
+29
to
+35
| await queryRunner.query( | ||
| `ALTER TABLE "findings" ALTER COLUMN "resolver" SET DATA TYPE uuid | ||
| USING CASE | ||
| WHEN "resolver" IN ('SYSTEM_ACTOR', 'Yaku', 'Aqua') THEN '00000000-0000-0000-0000-000000000000'::uuid | ||
| ELSE "resolver"::uuid | ||
| END`, | ||
| ) |
There was a problem hiding this comment.
That's exactly what I meant, nice job :)
| @@ -21,9 +21,9 @@ import { SYSTEM_REQUEST_USER } from '../module.utils' | |||
|
|
|||
| const CACHE_TIMEOUT = 1000 * 60 * 5 // 5 minutes | |||
| export const SYSTEM_USER = new UserInNamespaceDto() | |||
| SYSTEM_USER.id = 'SYSTEM_ACTOR' | |||
| SYSTEM_USER.id = '00000000-0000-0000-0000-000000000000' | |||
There was a problem hiding this comment.
I think we can remove this user now as well.
As you replaced the other entries it should be not used anymore.
Just to prevent having two possibilities to use and to update.
There was a problem hiding this comment.
I cleaned-up any SYSTEM_USER references, only SYSTEM_REQUEST_USER is used now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces the usage of keycloak UUIDs.