Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial skeleton and design document for Native Auth features #7414

Closed
wants to merge 42 commits into from
Closed

Initial skeleton and design document for Native Auth features #7414

wants to merge 42 commits into from

Conversation

shenj
Copy link

@shenj shenj commented Nov 11, 2024

No description provided.

@github-actions github-actions bot added documentation Related to documentation. msal-browser Related to msal-browser package labels Nov 11, 2024
axhaferllari
axhaferllari reviewed Nov 22, 2024
View reviewed changes
lib/msal-native-auth/rollup.config.js Outdated Show resolved Hide resolved
lib/msal-native-auth/samples/SignInSample.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/package.json Outdated Show resolved Hide resolved
lib/msal-native-auth/samples/lib/msal-native-auth.samples.js Outdated Show resolved Hide resolved
lib/msal-native-auth/src/INativeAuthPublicClientApplication.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/NativeAuthConstants.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/NativeAuthPublicClientApplication.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/doc/tech-design/Tech Design.md Outdated Show resolved Hide resolved
lib/msal-native-auth/doc/tech-design/Tech Design.md Outdated Show resolved Hide resolved
axhaferllari
axhaferllari suggested changes Dec 6, 2024
View reviewed changes
Copy link

@axhaferllari axhaferllari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let sync offline to sync on my comments

lib/msal-browser/src/index.ts Show resolved Hide resolved
lib/msal-native-auth/src/INativeAuthPublicClientApplication.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/NativeAuthActionInputs.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/NativeAuthActionInputs.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/NativeAuthActionInputs.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/auth_flow/result/GetAccessTokenResult.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/auth_flow/result/ResetPasswordResult.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/auth_flow/result/SignInResult.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/auth_flow/state_handler/SignUpStateHandler.ts Outdated Show resolved Hide resolved
lib/msal-native-auth/src/error/NativeAuthApiError.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the samples Related to the samples apps for the library. label Dec 24, 2024
@github-actions github-actions bot added the msal-common Related to msal-common package label Dec 27, 2024
@github-actions github-actions bot removed the msal-common Related to msal-common package label Dec 30, 2024
@shenj shenj closed this Jan 8, 2025
@shenj shenj deleted the jiashen/sketeton branch January 8, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axhaferllari axhaferllari axhaferllari requested changes

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg will be requested when the pull request is marked ready for review hectormmg is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling will be requested when the pull request is marked ready for review tnorling is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz will be requested when the pull request is marked ready for review peterzenz is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag will be requested when the pull request is marked ready for review sameerag is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft will be requested when the pull request is marked ready for review konstantin-msft is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo will be requested when the pull request is marked ready for review jo-arroyo is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda will be requested when the pull request is marked ready for review lalimasharda is a code owner

@shylasummers shylasummers Awaiting requested review from shylasummers shylasummers will be requested when the pull request is marked ready for review shylasummers is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS will be requested when the pull request is marked ready for review bgavrilMS is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft will be requested when the pull request is marked ready for review Robbie-Microsoft is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. msal-browser Related to msal-browser package samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shenj @axhaferllari @nguyencuong2596