-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add credential_type plugin config #157
Conversation
Signed-off-by: Junjie Gao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 91.22% 91.65% +0.43%
==========================================
Files 16 17 +1
Lines 581 599 +18
Branches 72 74 +2
==========================================
+ Hits 530 549 +19
+ Misses 38 37 -1
Partials 13 13 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Junjie Gao <[email protected]>
5578763
to
6135d88
Compare
So before this PR, i.e., before adding plugin config |
through this flag: --plugin-config credential_type=xxxx |
I'm a bit confused, |
Before this PR, users could not set credential_type; it was chosen automatically by the library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is the plugin config credential_type
documented anywhere?
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Added documents. |
Feat:
Test:
Resolves #146 #154
Signed-off-by: Junjie Gao [email protected]