fix: temp exclude SKUs without compatible VM image #617
+250
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616
Description
Exclude from consideration VM SKUs that don't have a compatible (= tagged for NVMe) VM image in community image galleries - for now, until the VM images are properly tagged. The implementation only allows VM SKUs that support SCSI (defined as either declaring SCSI support in their DiskControllerType, or not declaring anything at all).
Possible alternative implementations (which we may consider in the future):
karpenter.azure.com/controller-disk-type
) to both instance types (derived from VM SKUs) and images (either statically or derived from image definition) and rely on requirements compatibility, and dynamically take VM SKUs without compatible image support out of consideration. This would have a side benefit of being able to selectcontroller-disk-type
.How was this change tested?
make presubmit
Does this change impact docs?
Release Note