Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increasing log verbosity of creating logs so we can measure the start and end of creation for different resources #613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Bryce-Soghigian
Copy link
Collaborator

Fixes #

Description
For performance runs It would be nice to have a kubelet SLO like metric that measures the latency in each step of bootstrapping for each node.

How was this change tested?
It wasn't

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


…interest to also record the start of the create not just the end for each of these steps
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12216324795

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.23%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/instance/instance.go 3 4 75.0%
Totals Coverage Status
Change from base Build 12167425051: 0.0%
Covered Lines: 37171
Relevant Lines: 39447

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants