Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Makefile test targets #606

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore: update Makefile test targets #606

merged 1 commit into from
Dec 4, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Dec 4, 2024

Fixes #

Description

  • Speed up ci-test (don't always run race checks)
  • Make presubmit the same as ci-test for consistency
  • Add license checks

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

@tallaxes tallaxes added area/testing Issues or PRs related to testing area/ci Issues or PRs related to ci labels Dec 4, 2024
@tallaxes tallaxes self-assigned this Dec 4, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12153435200

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 94.235%
Totals Coverage Status
Change from base Build 12153183432: 0.005%
Covered Lines: 37173
Relevant Lines: 39447
💛 - Coveralls

Bryce-Soghigian
Bryce-Soghigian approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tallaxes tallaxes merged commit 5b04593 into main Dec 4, 2024
12 checks passed
@tallaxes tallaxes deleted the tallaxes/makefile-update branch December 4, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian approved these changes

Assignees

@tallaxes tallaxes

Labels
area/ci Issues or PRs related to ci area/testing Issues or PRs related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tallaxes @coveralls @Bryce-Soghigian