Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(examples): QoL, add optional commented options to examples #594

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

charliedmcb
Copy link
Collaborator

Fixes #

Description
Quality of Life change to add useful options to the examples, but optional with comments.

These are ones I use a lot for testing. However, don't want them by default as they might lead to confusing behavior if unaware they are enabled.

How was this change tested?
I use these a lot. Just added them directly while commented out with a note on each.
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add to v1 examples?

@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12126550076

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 94.23%

Files with Coverage Reduction New Missed Lines %
pkg/cache/unavailableofferings.go 2 95.45%
Totals Coverage Status
Change from base Build 12110002976: -0.005%
Covered Lines: 37171
Relevant Lines: 39447

💛 - Coveralls

@charliedmcb charliedmcb merged commit 025fb78 into main Dec 2, 2024
11 of 12 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/addOptionalCommentedOptionsToExamples branch December 2, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants