Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add aks-node-viewer #590

Merged
merged 5 commits into from
Dec 2, 2024
Merged

chore: add aks-node-viewer #590

merged 5 commits into from
Dec 2, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Dec 1, 2024

Description

Adds aks-node-viewer to tooling

How was this change tested?

  • make presubmit followed by aks-node-viewer (and make az-node-viewer)

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added the area/devtools Issues or PRs related to devtools label Dec 1, 2024
@tallaxes tallaxes self-assigned this Dec 1, 2024
@coveralls
Copy link

coveralls commented Dec 1, 2024

Pull Request Test Coverage Report for Build 12126780109

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 94.235%

Totals Coverage Status
Change from base Build 12126774499: 0.005%
Covered Lines: 37173
Relevant Lines: 39447

💛 - Coveralls

Bryce-Soghigian
Bryce-Soghigian previously approved these changes Dec 1, 2024
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but looks good.

hack/toolchain.sh Show resolved Hide resolved
@tallaxes tallaxes merged commit 4b1ebfb into main Dec 2, 2024
11 checks passed
@tallaxes tallaxes deleted the tallaxes/aks-node-viewer branch December 2, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues or PRs related to devtools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants