Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Artifact Streaming integration for bootstrappingclient mode #542

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Artifact Streaming integration for bootstrappingclient mode #542

wants to merge 2 commits into from

Conversation

comtalyst
Copy link
Collaborator

Fixes #

Description
This will enable Artifact Streaming by default for nodes provisioned with bootstrappingclient mode.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@coveralls
Copy link

coveralls commented Oct 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12364217454

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 94.235%
Totals Coverage Status
Change from base Build 12167425051: 0.005%
Covered Lines: 37173
Relevant Lines: 39447
💛 - Coveralls

@comtalyst comtalyst marked this pull request as draft October 25, 2024 01:45
Bryce-Soghigian
Bryce-Soghigian approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an integration test validating that image pull is done faster? Maybe with one of the cocalc larger images? We can have a timeout on image pull to validate that streaming is working since the latency is so significant without artifact streaming.

image

@comtalyst
Copy link
Collaborator Author

This one haven't incorporate preview limitations yet. Will evaluate later if we decide to pursue this during its preview.
For now, this PR stays as draft and should not be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@comtalyst @coveralls @Bryce-Soghigian