test(e2e): disable flaky test empty nodes #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought we fixed the flakiness of this one, are you evaluating overall QOS numbers or most recent runs? Can we run the deflake job maybe to determine which ones we should keep? |
I had made this PR as I'd previously noticed a lot of failures. Still in draft mode as I wasn't sure on disabling yet. If already fixed, great! |
|
just observed it again, we can probably merge this in |
Bryce-Soghigian
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Have found this test to be somewhat flaky. Disabling it for now in order to improve test QoS, while a fix is worked on.
How was this change tested?
Nothing additional. This is purely disabling
*
Does this change impact docs?
Release Note