Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(make): fixing make + e2e by change to scope for role assignment create #39

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

charliedmcb
Copy link
Collaborator

@charliedmcb charliedmcb commented Nov 17, 2023

Fixes #

Description
On the newest CLI version --scope has become a required parameter, and --resource-group no longer exists, so updating our make commands to align with this:

How was this change tested?
Nothing additional
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@charliedmcb charliedmcb merged commit 334b902 into main Nov 17, 2023
16 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/changeToScopeForRoleAssignmentCreate branch November 17, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants