Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add location option to the e2e pipeline #37

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

charliedmcb
Copy link
Collaborator

@charliedmcb charliedmcb commented Nov 15, 2023

Fixes #

Description
Wanting to give us more flexibility for manual e2e testing, and/or any additional automated testing by opening up the ability to specify the location for a e2e test to be run in.

How was this change tested?
Here is the branch specific E2E test, which is also targeting eastus:
https://github.com/Azure/karpenter/actions/runs/6895118672/job/18758391880
Note: the failures are within GPU is an expected current quota issue, and PVC is flaky atm. With the overall confirmation of the tests running in the given region and the rest of the check-in tests passing, I'm completing this.
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@charliedmcb
Copy link
Collaborator Author

Old E2E run, pre-merge:
https://github.com/Azure/karpenter/actions/runs/6881901025

Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@charliedmcb charliedmcb merged commit fdcd317 into main Nov 16, 2023
32 of 36 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/addLocationParamToE2ETests branch November 16, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants